Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap datastore operations for deno-slack-data-mapper #2

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Jan 27, 2023

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

As an experiment, this PR swaps the native datastore operations for those in the deno-slack-data-mapper module. This comparison shows great simplifications provided for the put, delete, and (especially) query operations.

A note on the required property

The datastore schema properties are currently used as an input property in multiple functions and results in an internal error if the required property is contained in these attributes. To avoid this, additional logic was added to insert the required property for the actual datastore schema while leaving the properties untouched.

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg requested a review from seratch January 27, 2023 22:40
@misscoded
Copy link
Contributor

I'd like to have a larger discussion about introducing (or not) external libraries into our samples before we go this route

@zimeg
Copy link
Member Author

zimeg commented Jan 27, 2023

@misscoded absolutely! Just wanted to test this out and share the findings! Planning on keeping it in draft, but can close it if you'd prefer 😄

@misscoded
Copy link
Contributor

@E-Zim Sounds good and I'm glad you're testing it out. And nope, feel free to keep the issue open in the meantime!

Base automatically changed from initial-submission to main February 1, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants