Skip to content

build(deps): remove pytest lower bounds from testing requirements #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Jul 7, 2025

Summary

This PR removes the lower bounds of pytest following discussion in #1328 to support active versions 🚢 💨

Testing

🤖 In ci runs to follow.

Category

  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimeg zimeg requested review from WilliamBergamin and ewanek1 July 7, 2025 18:52
@zimeg zimeg self-assigned this Jul 7, 2025
@zimeg zimeg added dependencies Pull requests that update a dependency file tests labels Jul 7, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (1e69f1d) to head (ce3216c).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯

Just want to point out that we still officially support 3.6, but if we merge this change we may have issues testing with 3.6 locally, so we should drop official support for it in our next release

Other lower bound requirements are also present specifically for 3.6 it may be worth looking into them

@zimeg
Copy link
Member Author

zimeg commented Jul 14, 2025

@WilliamBergamin @ewanek1 Thank y'all both for the reviews!

Just want to point out that we still officially support 3.6, but if we merge this change we may have issues testing with 3.6 locally, so we should drop official support for it in our next release

This is a great callout that caused me to hold off on merging this for now - I'm not aware of the other changes needed to drop official 3.6 support.

If this can merge as is I think that'd be ideal, but please let me know if we should hold off more 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants