Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new arguments to admin.users.list API method #1230

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 2, 2023

This pull request adds two newly added options to https://api.slack.com/methods/admin.users.list

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Nov 2, 2023
@seratch seratch self-assigned this Nov 2, 2023
@seratch seratch added this to the 1.35.1 milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1230 (5c0d8da) into main (5222c91) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1230      +/-   ##
============================================
- Coverage     74.72%   74.54%   -0.19%     
+ Complexity     4071     4062       -9     
============================================
  Files           437      437              
  Lines         12855    12857       +2     
  Branches       1298     1298              
============================================
- Hits           9606     9584      -22     
- Misses         2491     2512      +21     
- Partials        758      761       +3     
Files Coverage Δ
...java/com/slack/api/methods/RequestFormBuilder.java 87.23% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 953a6b8 into slackapi:main Nov 2, 2023
4 checks passed
@seratch seratch deleted the admin_users_list_arg branch November 2, 2023 05:28
@seratch seratch modified the milestones: 1.35.1, 1.36.0 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant