Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RichTextBlock support to Block Kit Kotlin DSL builder #1376
Add RichTextBlock support to Block Kit Kotlin DSL builder #1376
Changes from 3 commits
dfbe0e4
47006b9
a892eb8
1be897c
3afa2dc
ab49bd2
12c2ea7
8aa01ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emoji method should accept two patterns:
overloading with string type may not work; if that's the case, skipping unicode here is okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://api.slack.com/reference/block-kit/blocks#emoji-element-type
I've implemented based on the documents, but yes I've seen that
RichTextSectionElement.Emoji
has those fields and will take a look for them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 1be897c
By the way, Kotlin allows for overloading but I think it can be confusing. With this interface:
The call
emoji("aaa")
is directed to the second one, and to use the first method then we should use a named parameter likeemoji(name = "aaa")
.So I've skipped the Unicode version for now, but also suggesting a different DSL like
emojiUnicode("U+AC00")
with little confidence.