Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from cookie value in OAuthStateUtils #1648

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Remove quotes from cookie value in OAuthStateUtils #1648

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2479532
Remove quotes from cookie value in OAuthStateUtils
memben Feb 1, 2025
e197436
chore: run black
memben Feb 3, 2025
d3853e8
Merge branch 'main' into fix-issue-1647
memben Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slack_sdk/oauth/state_utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def is_valid_browser(
for cookie in cookies:
values = cookie.split(";")
for value in values:
if value.strip() == f"{self.cookie_name}={state}":
# handle quoted cookie values (e.g. due to base64 encoding)
if value.strip().replace('"', "").replace("'", "") == f"{self.cookie_name}={state}":
return True
return False
Loading