Allow opting out of appearance transition callbacks on presenting view controller #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
PanModalPresentable
s to opt out of having appearance transition callbacks (viewWillAppear
etc.) called on the presenting view controller. (#47)Requirements (place an
x
in each[ ]
)Notes
testPresentableYValues
fails for me locally, but it wasn't relevant to this PR :)In #47, there's a request for a reason to avoid these calls. In our case, we're showing the modal with a blurred background, and we wanted the presenting view controller's content to continue updating (we stop updating in viewDidDisappear). I went with a property on
PanModalPresentable
to avoid breaking existing library users, who may rely on the current behavior.Thank you for sharing PanModal!