Fix ios 17.1+ issue #204
Open
Fix ios 17.1+ issue #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think I have access to approve pull requests on this repo anymore - I may create a personal fork if this is causing frequent issues |
|
That could be cool. I think this is causing frequent issues. |
|
The code doesn't work on iPad, do you know the reason? |
I have only tested it on iPhone. If you can make a basic project where the problem is reproduced I try to fix |
nafis042
approved these changes
Nov 16, 2023
|
does anybody find solution for iPad? |
nil-bae
added a commit
to kidsnote/iOS-PanModal
that referenced
this pull request
Dec 15, 2023
부터 dest viewController가 노출되지 않는 이슈 수정 사항 적용 (slackhq#204)
burakCokyildirim
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for ios 17.1+ versions when displaying certain UIViewControllers where
containerViewhas not yet been set.Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.