PR feedback

slackhq · Feb 7, 2024 · 34a7d97 · 34a7d97
1 parent ba7303a
commit 34a7d97
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/kaldb/src/main/java/com/slack/kaldb/server/RecoveryTaskCreator.java b/kaldb/src/main/java/com/slack/kaldb/server/RecoveryTaskCreator.java
@@ -218,8 +218,9 @@ public long determineStartingOffset(
       } else if (indexerConfig.getCreateRecoveryTasksOnStart()
           && indexerConfig.getReadFromLocationOnStart()
               == KaldbConfigs.KafkaOffsetLocation.LATEST) {
-        // todo - this appears to be able to create recovery tasks that have a start and end
-        // position of 0, which is invalid
+        // Todo - this appears to be able to create recovery tasks that have a start and end
+        // position of 0, which is invalid. This seems to occur when new clusters are initialized, and is
+        // especially problematic when indexers are created but never get assigned (ie, deploy 5, only assign 3).
         LOG.info(
             "CreateRecoveryTasksOnStart is set and ReadLocationOnStart is set to current. Reading from current and"
                 + " spinning up recovery tasks");