Bump com.google.errorprone:error_prone_core from 2.35.1 to 2.36.0 (#1165

)

* Bump com.google.errorprone:error_prone_core from 2.35.1 to 2.36.0

Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.35.1 to 2.36.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.35.1...v2.36.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add --should-stop=ifError=FLOW

* Remove extraneous >

* Collapse duplicate branches

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kyle-sammons <[email protected]>

astra/pom.xml

@@ -29,7 +29,7 @@
         <curator.version>5.7.1</curator.version>
         <log4j.version>2.24.2</log4j.version>
         <aws.sdk.version>2.29.24</aws.sdk.version>
-        <error.prone.version>2.35.1</error.prone.version>
+        <error.prone.version>2.36.0</error.prone.version>
         <junit.jupiter.version>5.11.3</junit.jupiter.version>
     </properties>
 
@@ -567,6 +567,7 @@
                         <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</arg>
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
                         <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
+                        <arg>--should-stop=ifError=FLOW</arg>
                         <!-- Error prone settings -->
                         <arg>
                             <!-- TODO: consider removing all specific error upgrades in favor of -Werror (all warnings as build errors) -->

astra/src/test/java/com/slack/astra/schema/SpanFormatterWithSchemaTest.java

@@ -603,13 +603,8 @@ public void testTraceProtoToLuceneDocumentTest() throws Exception {
                   assertThat(field.binaryValue().utf8ToString()).isEqualTo(tag.getVStr());
                 } else if (fieldType == FieldType.IP) {
                   assertThat(tag.getFieldType()).isEqualTo(Schema.SchemaFieldType.IP);
-                  if (field instanceof SortedDocValuesField) {
-                    assertThat(InetAddressPoint.decode(field.binaryValue().bytes).getHostName())
-                        .isEqualTo(tag.getVStr());
-                  } else {
-                    assertThat(InetAddressPoint.decode(field.binaryValue().bytes).getHostName())
-                        .isEqualTo(tag.getVStr());
-                  }
+                  assertThat(InetAddressPoint.decode(field.binaryValue().bytes).getHostName())
+                      .isEqualTo(tag.getVStr());
                 } else if (fieldType == FieldType.BYTE) {
                   assertThat(tag.getFieldType()).isEqualTo(Schema.SchemaFieldType.BYTE);
                   assertThat(field.numericValue().byteValue()).isEqualTo((byte) tag.getVInt32());