Expose merge throttling parameter #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
changed the title
vthacker
force-pushed
the
kaldb_recovery_task_should_not_block_threads
branch
from
5d1e25f to
ae900b6
Compare
vthacker
changed the title
This reverts commit f289e21.
vthacker
force-pushed
the
kaldb_recovery_task_should_not_block_threads
branch
from
ae900b6 to
034541a
Compare
vthacker
force-pushed
the
kaldb_recovery_task_should_not_block_threads
branch
from
140c697 to
d62b1c9
Compare
|
See #624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the recovery nodes we don't want to throttle merges. Throttling is useful when we want to balance indexing vs search performance.
However recovery nodes are not searchable while the recovery service is creating chunks. So we should be setting very high commit and refresh intervals ( which we have started doing last week ) and not throttling merges.
Another PR is tacking increasing the ram buffer size which also saw a significant improvement in overall throughput.
Requirements