Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID field to search protobuf #768

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Add ID field to search protobuf #768

merged 3 commits into from
Feb 12, 2024

Conversation

bryanlb
Copy link
Contributor

@bryanlb bryanlb commented Feb 9, 2024

Summary

Adds protobuf support for the new ID field, as this is causing exceptions throughout the pipeline.

java.lang.IllegalArgumentException: No enum constant com.slack.kaldb.metadata.schema.FieldType.ID
	at java.base/java.lang.Enum.valueOf(Enum.java:293)
	at com.slack.kaldb.metadata.schema.FieldType.valueOf(FieldType.java:33)
	at com.slack.kaldb.metadata.schema.LuceneFieldDef.<init>(LuceneFieldDef.java:18)
	at com.slack.kaldb.metadata.schema.LuceneFieldDefSerializer.fromLuceneFieldDefProto(LuceneFieldDefSerializer.java:27)
	at com.slack.kaldb.metadata.schema.ChunkSchemaSerializer.fromChunkSchemaProto(ChunkSchemaSerializer.java:32)
	at com.slack.kaldb.metadata.schema.ChunkSchemaSerializer.fromJsonStr(ChunkSchemaSerializer.java:53)
	at com.slack.kaldb.metadata.schema.ChunkSchema.deserializeFile(ChunkSchema.java:27)
	at com.slack.kaldb.chunk.ReadOnlyChunkImpl.handleChunkAssignment(ReadOnlyChunkImpl.java:230)
	at com.slack.kaldb.chunk.ReadOnlyChunkImpl.lambda$cacheNodeListener$0(ReadOnlyChunkImpl.java:146)
	at java.base/java.lang.VirtualThread.run(VirtualThread.java:309)

@bryanlb bryanlb marked this pull request as ready for review February 12, 2024 23:01
@bryanlb bryanlb merged commit 0a46d2d into master Feb 12, 2024
3 checks passed
@bryanlb bryanlb deleted the bburkholder/id-schema branch February 12, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants