Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump com.google.errorprone:error_prone_core from 2.23.0 to 2.26.1 #811

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Bump com.google.errorprone:error_prone_core from 2.23.0 to 2.26.1 #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion astra/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<curator.version>5.6.0</curator.version>
<log4j.version>2.23.1</log4j.version>
<aws.sdk.version>2.25.37</aws.sdk.version>
<error.prone.version>2.23.0</error.prone.version>
<error.prone.version>2.26.1</error.prone.version>
<junit.jupiter.version>5.10.2</junit.jupiter.version>
</properties>

Expand Down
1 change: 0 additions & 1 deletion astra/src/test/java/com/slack/astra/metadata/dataset/DatasetMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ public void testEqualsAndHashCode() {
DatasetMetadata datasetMetadata5 =
new DatasetMetadata(name, owner, throughputBytes, Collections.emptyList(), name);

assertThat(datasetMetadata1).isEqualTo(datasetMetadata1);
assertThat(datasetMetadata1).isNotEqualTo(datasetMetadata2);
assertThat(datasetMetadata1).isNotEqualTo(datasetMetadata3);
assertThat(datasetMetadata1).isNotEqualTo(datasetMetadata4);
Expand Down
1 change: 0 additions & 1 deletion astra/src/test/java/com/slack/astra/metadata/dataset/DatasetPartitionMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ public void testEqualsAndHashCode() {
new DatasetPartitionMetadata(
start.toEpochMilli(), end.toEpochMilli(), Collections.emptyList());

assertThat(datasetPartitionMetadata1).isEqualTo(datasetPartitionMetadata1);
assertThat(datasetPartitionMetadata1).isNotEqualTo(datasetPartitionMetadata2);
assertThat(datasetPartitionMetadata1).isNotEqualTo(datasetPartitionMetadata3);
assertThat(datasetPartitionMetadata1).isNotEqualTo(datasetPartitionMetadata4);
Expand Down
2 changes: 0 additions & 2 deletions astra/src/test/java/com/slack/astra/metadata/schema/ChunkSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ public void testChunkSchemaEqualsHashCode() {
metadataMap2.put("m2", "v2");
final ChunkSchema chunkSchema6 = new ChunkSchema(schemaName, fieldDefMap2, metadataMap2);

assertThat(chunkSchema1).isEqualTo(chunkSchema1);
assertThat(chunkSchema3).isEqualTo(chunkSchema3);
assertThat(chunkSchema1).isNotEqualTo(chunkSchema2);
assertThat(chunkSchema1).isNotEqualTo(chunkSchema3);
assertThat(chunkSchema1).isNotEqualTo(chunkSchema4);
Expand Down
1 change: 0 additions & 1 deletion astra/src/test/java/com/slack/astra/metadata/search/SearchMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ public void testEqualsAndHashCode() {
SearchMetadata searchMetadata1 = new SearchMetadata(name, snapshotName, url);
SearchMetadata searchMetadata2 = new SearchMetadata(name + "2", snapshotName, url);

assertThat(searchMetadata1).isEqualTo(searchMetadata1);
assertThat(searchMetadata1).isNotEqualTo(searchMetadata2);

Set<SearchMetadata> set = new HashSet<>();
Expand Down
1 change: 0 additions & 1 deletion astra/src/test/java/com/slack/astra/metadata/snapshot/SnapshotMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public void testEqualsAndHashCode() {
new SnapshotMetadata(
name + "2", path, startTime, endTime, maxOffset, partitionId, LOGS_LUCENE9);

assertThat(snapshot1).isEqualTo(snapshot1);
// Ensure the name field from super class is included.
assertThat(snapshot1).isNotEqualTo(snapshot2);
Set<SnapshotMetadata> set = new HashSet<>();
Expand Down
Loading