Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include androidTest information about projects if it's not enabled #507

Merged
merged 1 commit into from
Aug 8, 2023
+19 −16
Merged

Don't include androidTest information about projects if it's not enabled #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions slack-plugin/src/main/kotlin/slack/gradle/StandardProjectConfigurations.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,24 +475,27 @@ internal class StandardProjectConfigurations(
slackExtension.androidHandler.featuresHandler.androidTestExcludeFromFladle.getOrElse(
false
)
if (!excluded && isAffectedProject) {
computeAffectedProjectsTask.configure { androidTestProjects.add(projectPath) }
if (isLibraryVariant) {
(variant as LibraryVariant).androidTest?.artifacts?.get(SingleArtifact.APK)?.let {
apkArtifactsDir ->
// Wire this up to the aggregator
androidTestApksAggregator.configure { androidTestApkDirs.from(apkArtifactsDir) }
val isAndroidTestEnabled = variant is HasAndroidTest && variant.androidTest != null
if (isAndroidTestEnabled) {
if (!excluded && isAffectedProject) {
computeAffectedProjectsTask.configure { androidTestProjects.add(projectPath) }
if (isLibraryVariant) {
(variant as LibraryVariant).androidTest?.artifacts?.get(SingleArtifact.APK)?.let {
apkArtifactsDir ->
// Wire this up to the aggregator
androidTestApksAggregator.configure { androidTestApkDirs.from(apkArtifactsDir) }
}
}
}
} else {
val reason = if (excluded) "excluded" else "not affected"
val taskPath = "${projectPath}:androidTest"
val log = "$LOG Skipping $taskPath because it is $reason."
slackTools.logAvoidedTask(AndroidTestApksTask.NAME, taskPath)
if (slackProperties.debug) {
project.logger.lifecycle(log)
} else {
project.logger.debug(log)
val reason = if (excluded) "excluded" else "not affected"
val taskPath = "${projectPath}:androidTest"
val log = "$LOG Skipping $taskPath because it is $reason."
slackTools.logAvoidedTask(AndroidTestApksTask.NAME, taskPath)
if (slackProperties.debug) {
project.logger.lifecycle(log)
} else {
project.logger.debug(log)
}
}
}
}
Expand Down
Loading