Update Jewel to Latest Version (0.24.2) #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Sep 23, 2024
kateliu20
changed the title
ZacSweers
reviewed
Sep 23, 2024
skate-plugin/project-gen/src/jvmMain/kotlin/slack/tooling/aibot/PainterResource.kt
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 23, 2024
| @@ -28,7 +28,7 @@ import org.jetbrains.compose.resources.decodeToSvgPainter | |||
|
|
|||
| // Migration snippet copied from https://github.com/JetBrains/compose-multiplatform-core/pull/1457 | |||
| // To resolve deprecated painterResource function from upgrading compose-jb | |||
| class PainterResource { | |||
| object PainterResource { | |||
There was a problem hiding this comment.
Does it need to be an object vs top-level functions?
There was a problem hiding this comment.
Ah yeah it doesn't need to be top-level. I wrapped it in the class originally because I was afraid it would call the deprecated painterResource function, but since I removed the import it should be good. I think I should remove the object :
d432093
ZacSweers
approved these changes
Sep 23, 2024
Yeah I checked that already! Definitely didn't want a repeat. I will continue to make adjustments to the UI independently and after talking with designers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #937 which was reverted due to not upgrading to IJ platform 2.0.1 yet, but now is done here: #973.