Support removing HHAST async fixmes

src/analyzer/function_analysis_data.rs

@@ -527,9 +527,6 @@ impl FunctionAnalysisData {
 
         for hakana_fixme_or_ignores in &self.hakana_fixme_or_ignores {
             for line_issue in hakana_fixme_or_ignores.1 {
-                if line_issue.0 == IssueKind::NoJoinInAsyncFunction {
-                    continue;
-                }
                 if !self
                     .matched_ignore_positions
                     .contains(&(line_issue.1 .0, line_issue.1 .1))

tests/remove-unused-fixmes/removeHHASTFixme/input.hack

@@ -1,3 +1,4 @@
-function foo(): void {
-    echo(/* HAKANA_FIXME[NoValue] */ 5);
+async function foo(): Awaitable<void> {
+    /* HHAST_FIXME[NoJoinInAsyncFunction] */
+    echo(5);
 }

tests/remove-unused-fixmes/removeHHASTFixme/output.txt

@@ -1,3 +1,3 @@
-function foo(): void {
+async function foo(): Awaitable<void> {
     echo(5);
 }

tests/remove-unused-fixmes/removeHakanaFixme/input.hack

@@ -0,0 +1,3 @@
+function foo(): void {
+    echo(/* HAKANA_FIXME[NoValue] */ 5);
+}

tests/remove-unused-fixmes/removeHakanaFixme/output.txt

@@ -0,0 +1,3 @@
+function foo(): void {
+    echo(5);
+}