Allow more unused methods to be covered by fixmes

slackhq · Apr 22, 2024 · 393aec3 · 393aec3
1 parent 23587c2
commit 393aec3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/src/file_scanner_analyzer/unused_symbols.rs b/src/file_scanner_analyzer/unused_symbols.rs
@@ -287,14 +287,6 @@ pub(crate) fn find_unused_definitions(
 
                         let method_storage = functionlike_storage.method_info.as_ref().unwrap();
 
-                        if functionlike_storage
-                            .suppressed_issues
-                            .iter()
-                            .any(|(i, _)| i == &IssueKind::UnusedPrivateMethod)
-                        {
-                            continue;
-                        }
-
                         // allow one-liner private construct statements that prevent instantiation
                         if *method_name_ptr == StrId::CONSTRUCT
                             && matches!(method_storage.visibility, MemberVisibility::Private)
@@ -358,6 +350,14 @@ pub(crate) fn find_unused_definitions(
                                 )
                             };
 
+                        if functionlike_storage
+                            .suppressed_issues
+                            .iter()
+                            .any(|(i, _)| i == &issue.kind)
+                        {
+                            continue;
+                        }
+
                         let file_path = interner.lookup(&pos.file_path.0);
 
                         if !config.allow_issue_kind_in_file(&issue.kind, file_path) {

diff --git a/tests/unused/UnusedCode/coverByFixme/input.hack b/tests/unused/UnusedCode/coverByFixme/input.hack
@@ -0,0 +1,10 @@
+class A {
+    /* HAKANA_FIXME[UnusedPublicOrProtectedMethod] */
+    public function foo(): void {
+    }
+}
+
+<<__EntryPoint>>
+function main(): void {
+    new A();
+}