Write analysis JSON to provided file, format #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hakana analyze
only respects--output
if the filename is "checkpoint_results.json". This PR changes the command to writes the output to any given path and adds--json-format
to specify the desired output format.The options allowed for
--json-format
are:checkpoint
: the current defaulthh_client
: format that can be interpreted in the same way as error messages from Meta's Hack typecheckerfull
: the issue and description with all information from the HPosAfter adding
hh_client
and documenting the meaning of start and end, I opted to addfull
because it's easier to work with. Details inline; happy to drophh_client
entirely. Can also renamefull
if desired.