-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find executable code for coverage analysis #23
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Petr Pchelko <p***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
This looks good! You might want to look at the test file config to only generate for production files |
Thanks for the contribution! Before we can merge this, we need @Pchelolo to sign the Salesforce Inc. Contributor License Agreement. |
Couldn't really figure out how to do that. Will try in a followup - there's still work to be done to properly classify various things as covered/non-covered. But we'd like to release this to try it out in read CI and make bug finding more collaborative. |
f79942b
to
e4c6ca2
Compare
We want to be able to find all "executable" lines in the hack codebase in order to compute test coverage.
This sets up the backbone for the new command, runs a visitor over all files in the codebase and outputs the results in a file. Right now we output start and end of each statement. It's not perfect, but I'll make adjustments in followups.