Skip to content

Commit

Permalink
fix roaming check
Browse files Browse the repository at this point in the history
We need to compare just the IPs here and not the IP+Port

This is a regression with the merge of v1.9.4 and the change to
netip.AddrPort

- dabce8a
  • Loading branch information
wadey committed Oct 2, 2024
1 parent dabce8a commit 7ac51c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion outside.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func (f *Interface) handleHostRoaming(hostinfo *HostInfo, ip netip.AddrPort) {
if hostinfo.multiportRx {
// If the remote is sending with multiport, we aren't roaming unless
// the IP has changed
if hostinfo.remote.Compare(ip) == 0 {
if hostinfo.remote.Addr().Compare(ip.Addr()) == 0 {
return
}
// Keep the port from the original hostinfo, because the remote is transmitting from multiport ports
Expand Down

0 comments on commit 7ac51c1

Please sign in to comment.