Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #1046

Merged
merged 2 commits into from
May 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 18, 2023
@wadey wadey added this to the v1.9.0 milestone Dec 19, 2023
@wadey
Copy link
Member

wadey commented Dec 21, 2023

Looks like we need to fix some things here:

Run actions/upload-artifact@v4
  with:
    name: e2e packet flow
    path: e2e/mermaid/
    if-no-files-found: warn
    compression-level: 6
With the provided path, there will be 13 files uploaded
Artifact name is valid!
Root directory input is valid!

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

It is mentioned here: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

@wadey
Copy link
Member

wadey commented Dec 21, 2023

@wadey
Copy link
Member

wadey commented Dec 21, 2023

I also see this, which might be an issue with our release workflow? We could probably zip then all together before putting into artifacts:

Limit of Artifacts for an individual job. Each job in a workflow run now has a limit of 10 artifacts.

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from cb23b76 to 00a1257 Compare December 21, 2023 17:00
@wadey wadey modified the milestones: v1.9.0, v1.10.0 Apr 22, 2024
@wadey
Copy link
Member

wadey commented Apr 30, 2024

This was deprecated and will be removed Nov 30th: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@wadey wadey modified the milestones: v1.10.0, v1.9.0 May 2, 2024
@wadey wadey merged commit aa18d7f into master May 2, 2024
5 checks passed
@wadey wadey deleted the dependabot/github_actions/actions/upload-artifact-4 branch May 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants