Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deadlock in GetOrHandshake #1151

Merged
merged 1 commit into from
May 29, 2024
Merged

remove deadlock in GetOrHandshake #1151

merged 1 commit into from
May 29, 2024

Commits on May 28, 2024

  1. remove deadlock in GetOrHandshake

    We had a rare deadlock in GetOrHandshake because we kept the hostmap
    lock when we do the call to StartHandshake. StartHandshake can block
    while sending to the lighthouse query worker channel, and that worker
    needs to be able to grab the hostmap lock to do its work. Other calls
    for StartHandshake don't hold the hostmap lock so we should be able to
    drop it here.
    
    This lock was originally added with: #954
    wadey committed May 28, 2024
    Configuration menu
    Copy the full SHA
    6764b9d View commit details
    Browse the repository at this point in the history