Default pki.disconnect_invalid to true and make it reloadable
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasikpark
reviewed
May 4, 2023
nbrownus
force-pushed
the
default-disconnect-invalid
branch
from
6e6e895
to
8cdb7d7
Compare
johnmaguire
reviewed
Oct 19, 2023
| @@ -170,7 +169,6 @@ func NewInterface(ctx context.Context, c *InterfaceConfig) (*Interface, error) { | |||
| writers: make([]*udp.Conn, c.routines), | |||
| readers: make([]io.ReadWriteCloser, c.routines), | |||
| caPool: c.caPool, | |||
| disconnectInvalid: c.disconnectInvalid, | |||
There was a problem hiding this comment.
Do we need ifce.disconnectInvalid.Store(c.disconnectInvalid) below?
There was a problem hiding this comment.
It looks like no, because we call ifce.reloadDisconnectInvalid(c) after calling NewInterface from main.go.
This is contrast to ifce.certState which is handled internally in this function.
I think this approach is a little awkward because the caller may not be aware they need to initialize this value.
nbrownus
force-pushed
the
default-disconnect-invalid
branch
from
8cdb7d7
to
1ac02c5
Compare
nbrownus
force-pushed
the
default-disconnect-invalid
branch
from
a1a2510
to
11bacce
Compare
johnmaguire
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #838 merged there is a path to refresh certificates and rekey tunnels without having to restart the nebula process. It would be a good practice to flip this to
true.