Reduce what HostInfo.ConnectionState keeps track of
#953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadey
previously approved these changes
Aug 14, 2023
There was a problem hiding this comment.
I think we had to do this before because things would expect the cs to already be set and to be able to lock around it as soon as the hostinfo entered the pending host map: #535
I think with the refactor to remove pending Hostmap this shouldn't be a problem, but we should ensure we have removed the race conditions that caused us to need to fix #535 in the first place before we merge this.
nbrownus
force-pushed
the
no-cert-state
branch
from
faa655a
to
d01cb2f
Compare
wadey
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConnectionStatestruct doesn't need the entireCertStateobject, this reworks things slightly to make it so we only need to keep track of the local certificate.