Fix metadata field rendering and log off-by-one error #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When initially converting from the Grafana
DataFrame
to a normal log object, we were being a bit lazy and just using the_source
object. That resulted in us not having access to metadata fields (such as_id
,_timesinceepoch
, etc). This PR properly implements theDataFrame
->Log
conversion giving us back access to the metadata fields.Resolves: #50
We also were running into an issue that was caused by forgetting that the row index in the table and the index of the log we're rendering are going to be off by one due to the table header. This manifested as a search with one log not displaying anything.
Resolves: #49
Requirements (place an
x
in each[ ]
)