Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the histogram rendering in Grafana 10 #52

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

kyle-sammons
Copy link
Collaborator

Summary

Currently under Grafana 10.x, the histogram rendering for this plugin is broken. This is due to a subtle and slight shift to the data returned by one of the APIs. This PR fixes it so that it works under both 9.x and 10.x

Demo

Using Grafana 10.3

Grafana Histogram 10 3 1

Using Grafana 9.5

Grafana Histogram 9 5

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

bryanlb
bryanlb previously approved these changes Feb 14, 2024
src/pages/explore.tsx Outdated Show resolved Hide resolved
@kyle-sammons kyle-sammons merged commit 7d4ec4e into master Feb 14, 2024
2 checks passed
@kyle-sammons kyle-sammons deleted the ksammons-fix-histogram-on-Grafana-10 branch February 14, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants