Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable value class checking for issue repro #88

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable value class checking for issue repro #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions slack-lint-checks/src/main/java/slack/lint/mocking/MockDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class MockDetector : Detector(), SourceCodeScanner {
AutoValueMockDetector,
ObjectClassMockDetector,
RecordClassMockDetector,
ValueClassMockDetector,
)
val ISSUES = TYPE_CHECKERS.map2Array { it.issue }
}
Expand Down
4 changes: 2 additions & 2 deletions slack-lint-checks/src/test/java/slack/lint/mocking/ValueClassMockDetectorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import org.junit.Ignore
import org.junit.Test
import slack.lint.BaseSlackLintTest

@Ignore("https://issuetracker.google.com/issues/283715187")
//@Ignore("https://issuetracker.google.com/issues/283715187")
class ValueClassMockDetectorTest : BaseSlackLintTest() {

private val testClass =
Expand Down Expand Up @@ -43,7 +43,7 @@ class ValueClassMockDetectorTest : BaseSlackLintTest() {
@Spy lateinit var fieldSpy: TestClass

fun example() {
// val localMock1 = org.mockito.Mockito.mock(TestClass::class.java)
val localMock1 = org.mockito.Mockito.mock(TestClass::class.java)
val localSpy1 = org.mockito.Mockito.spy(1u)
// val localMock2 = mock<TestClass>()
// val classRef = TestClass::class.java
Expand Down