WIP: Stable client indexes for target selection #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Robinson <[email protected]>
demmer
reviewed
Jan 21, 2025
| @@ -319,11 +320,16 @@ func (b *JSONGateResolverBuilder) parse() (bool, error) { | |||
| // target lock and then comparing the previous targets with the current | |||
| // targets and only resetting pools which disappear. | |||
| targetCount.ResetAll() | |||
|
|
|||
| idx := getClientIndex() | |||
| for poolType := range targets { | |||
| b.sorter.shuffleSort(targets[poolType], b.affinityField, b.affinityValue) | |||
There was a problem hiding this comment.
Presumably for this approach we'd want to not do the random shuffleSort and instead make sure that the targets list is in a stable order?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.