Support Hack root in an arbitrary subdirectory #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit hesitant to ship this because people have already complained about too many confusing path configurations in this extension, and this adds one more in the mix |
PranayAgarwal
requested changes
Jul 15, 2020
|
@PranayAgarwal, sorry this took me ~8 months to respond to your changes, I got sidetracked on other side projects :/ Please take another look when you get a chance |
|
I no longer use HHVM so I'm going to close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #94
This didn't end up being as easy as I hypothesized in the issue, but this seems like the best way to support a non-workspace root for Hack code.