Updated FSM to latch meta data #1233
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmishra9 Have you and Jeremy built this FW and tested in the actual hardware yet to see if it fixes the issue? Are you able to force a overflow event to confirm that the FW and kernel driver has the behavior you want? |
slacrherbst
reviewed
Feb 5, 2025
There was a problem hiding this comment.
@mmishra9 This is not correct. DUMP_S needs to go to RETURN_S if meta is not enabled, similiar to the if statement included at the end of the PAD_S state. This will result in data corruption somewhere if meta is not enabled, i.e. the datagpu standard to host DMAs.
slacrherbst
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated FSM to latch the meta data to the AXIS in AxiStreamDmaV2Write.vhd. The 'overflow' bit should now be available in the AXIS header.