Skip to content

Commit

Permalink
feat: bugfix for error on init of C# repos (#513)
Browse files Browse the repository at this point in the history
secureli-512

<!-- Include general description here -->
Secureli init failed/errors out on initialization of repo with C#
language. This PR resolves that issue.

## Changes
<!-- A detailed list of changes -->
* Made 'rev' property on pre-commit repo setting optional.

## Testing
<!--
Mention updated tests and any manual testing performed.
Are aspects not yet tested or not easily testable?
Feel free to include screenshots if appropriate.
 -->
* All existing unit tests passing

## Clean Code Checklist
<!-- This is here to support you. Some/most checkboxes may not apply to
your change -->
- [x] Meets acceptance criteria for issue
- [ ] New logic is covered with automated tests
- [ ] Appropriate exception handling added
- [ ] Thoughtful logging included
- [ ] Documentation is updated
- [ ] Follow-up work is documented in TODOs
- [ ] TODOs have a ticket associated with them
- [x] No commented-out code included


<!--
Github-flavored markdown reference:
https://docs.github.com/en/get-started/writing-on-github
-->
  • Loading branch information
isaac-heist-slalom authored Apr 18, 2024
1 parent bc263ea commit 4a7efc2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .secureli/.pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
# See https://pre-commit.com/hooks.html for more hooks
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
rev: v4.6.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-yaml
- id: check-added-large-files
- repo: https://github.com/psf/black-pre-commit-mirror
rev: 24.3.0
rev: 24.4.0
hooks:
- id: black
- repo: https://github.com/yelp/detect-secrets
Expand Down
2 changes: 1 addition & 1 deletion secureli/repositories/repo_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class PreCommitRepo(BaseModel):
"""

url: str = Field(alias="repo")
rev: str
rev: Optional[str]
hooks: list[PreCommitHook] = Field(default=[])
suppressed_hook_ids: list[str] = Field(default=[])

Expand Down

0 comments on commit 4a7efc2

Please sign in to comment.