-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 154 Prompt User to Install Code Linters for each Detected Language #332
feat: 154 Prompt User to Install Code Linters for each Detected Language #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title failed to match (chore|style|test|feat|fix|docs): .+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my as-yet limited knowledge of Secureli, I think looks good but I left some minor comments.
…ub.com:slalombuild/secureli into feature/secureli-154-prompt-to-install-linters
closes #154
Overview
Adds functionality to prompt the user to determine if linter based pre-commit hooks should be added to the code repository. The user will be prompted for each detected language during
init
.An example messages will be
Add lint pre-commit(s) for JavaScript? [Y/n]
adding the
--yes
option will bypass the prompting to install linter pre-commit hooks and will automatically add them.Technical Approach
This pr includes reorganizing the pre-commit templates into a new folder/file structure. Templates will be located under
resources/pre-commit
and will be split into separate folders and files based on if they are linter hooks or not. The user responses and code will determine whether or not the hooks should be combined and saved to the user's repository. Splitting these files out ensures a simple way of knowing which hooks are linters.Testing
secureli init
Regression testing:
Testing
scan
andupdate
to ensure both are working as normal.