feat: Only publish metrics on commit #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kind of the whole point of seCureLI
This introduces a command-line param that allows for opt-in to publishing results to New Relic, but it is enabled by default when scanning as a pre-commit hook
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tdurk93
changed the title
kevin-orlando
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only detecting scan vs commit scenarios, I added a CLI param to set when metrics should be published (
always,never, oron-fail) and utilized that by setting the git pre-commit hook tosecureli scan --publish-results=always.One other notable change is that I added a
models/directory. I think it would make sense to migrate various pydantic models & enums there in the future.Testing