Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace unsupported google eslint with eslint recommended #356

Merged
merged 6 commits into from
Jan 10, 2024
Merged

chore: replace unsupported google eslint with eslint recommended #356

merged 6 commits into from
Jan 10, 2024

Conversation

kevin-orlando
Copy link
Contributor

@kevin-orlando kevin-orlando commented Jan 9, 2024 •
edited
Loading

closes #337

  • Replace the eslint-google-config settings with eslint:recommended for generated typescript and javascript eslint config files.

  • Add missing module identify to homebrew formula

  • Fix lint config issues

    1. Fix mismatched file names in pre-commit file and config files
    2. Create separate files for JavaScript and TypeScript
    3. Add missing dependency for needed TypeScript pre-commit file

@kevin-orlando kevin-orlando requested a review from tdurk93 January 10, 2024 19:08
@kevin-orlando kevin-orlando merged commit f86b5d3 into main Jan 10, 2024
6 checks passed
@kevin-orlando kevin-orlando deleted the feature/secureli-337-replace-google-eslint branch January 10, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurk93 tdurk93 tdurk93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace eslint-config-google in the ESLint configurations
3 participants
@kevin-orlando @tdurk93 @calebtonn