Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 451 audit utilities directory #476

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat: 451 audit utilities directory #476

merged 2 commits into from
Mar 13, 2024

Conversation

isaac-heist-slalom
Copy link
Contributor

secureli-451

Changes

  • Updated utility files by moving to appropriate modules and combining to single utilities.py file.

Testing

  • All existing unit tests are passing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@isaac-heist-slalom isaac-heist-slalom marked this pull request as ready for review March 11, 2024 23:00
@isaac-heist-slalom isaac-heist-slalom linked an issue Mar 11, 2024 that may be closed by this pull request
Audit Utilities Directory #451
Closed
JordoHeffernan
JordoHeffernan reviewed Mar 13, 2024
View reviewed changes
secureli/modules/shared/utilities.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better, thank you!

@isaac-heist-slalom isaac-heist-slalom merged commit 83bedc1 into refactor/secureli-000-modular-refactor Mar 13, 2024
3 checks passed
@isaac-heist-slalom isaac-heist-slalom deleted the feature/secureli-451-audit-utilities-directory branch March 13, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordoHeffernan JordoHeffernan JordoHeffernan approved these changes

@bobm-slalom bobm-slalom Awaiting requested review from bobm-slalom

@kathleen-hogan-slalom kathleen-hogan-slalom Awaiting requested review from kathleen-hogan-slalom

@kevin-orlando kevin-orlando Awaiting requested review from kevin-orlando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit Utilities Directory
2 participants
@isaac-heist-slalom @JordoHeffernan