Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tests for language detection #532

Merged
merged 7 commits into from
Apr 26, 2024
Merged

feat: tests for language detection #532

merged 7 commits into from
Apr 26, 2024

Conversation

ambhrin-slalom
Copy link
Contributor

secureli-XXX

Changes

Testing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

github-actions[bot]
github-actions bot previously requested changes Apr 24, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match (chore|style|test|feat|fix|docs|ci): .+

@ambhrin-slalom ambhrin-slalom changed the title tests for language detection feat: tests for language detection Apr 24, 2024
@github-actions github-actions bot dismissed their stale review April 24, 2024 17:19

All good!

@isaac-heist-slalom isaac-heist-slalom linked an issue Apr 25, 2024 that may be closed by this pull request
Set up happy path tests to run on remote repos of other supported languages #129
Closed
@ambhrin-slalom ambhrin-slalom marked this pull request as ready for review April 26, 2024 17:44
isaac-heist-slalom
isaac-heist-slalom approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@isaac-heist-slalom isaac-heist-slalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ambhrin-slalom ambhrin-slalom merged commit 454ec28 into main Apr 26, 2024
5 checks passed
@ambhrin-slalom ambhrin-slalom deleted the feature/secureli-129-lang-detect branch April 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-heist-slalom isaac-heist-slalom isaac-heist-slalom approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up happy path tests to run on remote repos of other supported languages
2 participants
@ambhrin-slalom @isaac-heist-slalom