Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Exit codes and updated unit tests #547 #548

Merged
merged 5 commits into from
Jun 27, 2024
Merged

feat: Added Exit codes and updated unit tests #547 #548

merged 5 commits into from
Jun 27, 2024

Conversation

LaKeishaTurnerSlalom
Copy link
Contributor

secureli-375
#375

Added Additional Exit Codes based on error types as discussed. Passing exitCode to the ScanFailure class

Changes

  • Added Exit Codes
  • Updated ScanFailure
  • Updated Unit Tests
  • Verified no additional errors

Testing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

rt-slalom
rt-slalom reviewed May 15, 2024
View reviewed changes
javascript.eslintrc.yaml Outdated Show resolved Hide resolved
@LaKeishaTurnerSlalom LaKeishaTurnerSlalom removed the request for review from isaac-heist-slalom May 15, 2024 15:24
@ian-bowden-slalom ian-bowden-slalom merged commit c1b55b3 into main Jun 27, 2024
5 checks passed
@ian-bowden-slalom ian-bowden-slalom deleted the feature/secureli-375-ExitCodes branch June 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt-slalom rt-slalom rt-slalom left review comments

@doug-szeto-slalom doug-szeto-slalom doug-szeto-slalom approved these changes

@itoltz itoltz itoltz approved these changes

@shrutitirpude shrutitirpude shrutitirpude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LaKeishaTurnerSlalom @rt-slalom @shrutitirpude @itoltz @doug-szeto-slalom @ian-bowden-slalom