Feature/secureli 460 custom regex #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itoltz
approved these changes
Jun 10, 2024
|
Code looks good. Could you add some info about this new feature to |
itoltz
approved these changes
Jun 11, 2024
shrutitirpude
pushed a commit
that referenced
this pull request
Jun 11, 2024
secureli-460 Adds new `new-pattern` parameter to `secureli update` and updates `secureli scan` to check for custom regex ## Changes * ## Testing <!-- Mention updated tests and any manual testing performed. Are aspects not yet tested or not easily testable? Feel free to include screenshots if appropriate. --> * run `secureli update --new-pattern <custom-regex-pattern>` * verify that your custom regex pattern was added to `.secureli.yaml` * modify any file (other than .secureli.yaml) to include text that matches your custom regex * stage the changes * run `secureli scan` and verify the scan fails * revert the changes and run `secureli scan` and verify the scan passes ## Clean Code Checklist <!-- This is here to support you. Some/most checkboxes may not apply to your change --> - [x] Meets acceptance criteria for issue - [x] New logic is covered with automated tests - [ x Appropriate exception handling added - [x] Thoughtful logging included - [x] Documentation is updated - [x] Follow-up work is documented in TODOs - [x] TODOs have a ticket associated with them - [x] No commented-out code included <!-- Github-flavored markdown reference: https://docs.github.com/en/get-started/writing-on-github --> --------- Co-authored-by: Rachel Teal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secureli-460
Adds new
new-patternparameter tosecureli updateand updatessecureli scanto check for custom regexChanges
Testing
secureli update --new-pattern <custom-regex-pattern>.secureli.yamlsecureli scanand verify the scan failssecureli scanand verify the scan passesClean Code Checklist