fix: created mock to override file open #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ian-bowden-slalom
changed the title
ian-bowden-slalom
changed the title
shrutitirpude
approved these changes
Jun 28, 2024
shrutitirpude
approved these changes
Jul 8, 2024
gabenegron
approved these changes
Jul 8, 2024
ian-bowden-slalom
deleted the
feature/secureli-577-stop-unit-tests-from-modifying-config-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mocks the builtins.open for the test_that_update_with_new_pattern_succeeds test so that the test doesn't open and modify the actual secureli.yaml file in the repository
Tested that all tests still pass and that the secureli file is no longer modified after running tests
Clean Code Checklist