Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 1165 show language names #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sleepyyapril
Copy link
Owner

Description

Description.


TODO

  • Task
  • Completed Task

Media

Example Media Embed


Changelog

🆑

  • add: Added fun :D
  • tweak: Tweaked fun
  • fix: Fixed fun!
  • remove: Removed fun :(

sleepyyapril and others added 7 commits November 13, 2024 21:04
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

One word change; silver was named incorrectly.
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Contains a single system, under the server-sided AutoVote folder, that
handles automatic voting of maps and presets, both of which are
configurable via a CVar.

By automatic voting system, I mean that it creates a vote for map and
preset the moment players return to lobby. If the server just started
and there are no players, it will run the vote when a player joins to
lobby.

As of now, the best use case for this is for your players to play the
modes they want, at all times.

Relevant CVars:
`vote.autovote_enabled - Is the autovote system enabled at all? (Default
is false)`
`vote.map_autovote_enabled - If it is applicable, is automatic map
voting enabled? (Default is true)`
`vote.preset_autovote_enabled - If it is applicable, is automatic preset
voting enabled? (Default is true)`

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Base system
- [x] CVars
- [x] Set default CVar value to false, as it is not something you might
want by default.

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added the automatic voting system.

---------

Signed-off-by: sleepyyapril <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
Caused a debug assert due to the component not being real.
# Description
1. Adds languages to... penguins, cockroaches, snakes, mmis, pdas, mail
packages. Positronic brains now only speak/understand the borg language.
2. Adds an explicitly defined universal language to revenants and wisps
3. Makes polymorphs copy over a list of components defined in the
polymorph proto, thus copying languages and grammar of the original
entity to its polymorphed version.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/111c3f91-f077-431f-bcd9-f60fa7a1ba26)


![image](https://github.com/user-attachments/assets/80f939d3-b615-4235-a511-82238758788e)


![image](https://github.com/user-attachments/assets/dce99b55-c8b1-4cbe-8769-b82151b3d404)


![image](https://github.com/user-attachments/assets/6b9b962d-c73c-42b9-b240-aa07601de879)



</p>
</details>

# Changelog
:cl:
- tweak: Added languages to certain entities that lacked them, including
MMIs and positronic brains.
- add: Polymorphing into another entity now preserves your languages and
grammar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants