forked from Simple-Station/Einstein-Engines
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 1165 show language names #1
Open
sleepyyapril
wants to merge
7
commits into
master
Choose a base branch
from
revert-1165-Show-Language-Names
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> One word change; silver was named incorrectly.
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Contains a single system, under the server-sided AutoVote folder, that handles automatic voting of maps and presets, both of which are configurable via a CVar. By automatic voting system, I mean that it creates a vote for map and preset the moment players return to lobby. If the server just started and there are no players, it will run the vote when a player joins to lobby. As of now, the best use case for this is for your players to play the modes they want, at all times. Relevant CVars: `vote.autovote_enabled - Is the autovote system enabled at all? (Default is false)` `vote.map_autovote_enabled - If it is applicable, is automatic map voting enabled? (Default is true)` `vote.preset_autovote_enabled - If it is applicable, is automatic preset voting enabled? (Default is true)` --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Base system - [x] CVars - [x] Set default CVar value to false, as it is not something you might want by default. --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - add: Added the automatic voting system. --------- Signed-off-by: sleepyyapril <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]> Co-authored-by: FoxxoTrystan <[email protected]> Co-authored-by: VMSolidus <[email protected]>
Caused a debug assert due to the component not being real.
# Description 1. Adds languages to... penguins, cockroaches, snakes, mmis, pdas, mail packages. Positronic brains now only speak/understand the borg language. 2. Adds an explicitly defined universal language to revenants and wisps 3. Makes polymorphs copy over a list of components defined in the polymorph proto, thus copying languages and grammar of the original entity to its polymorphed version. <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/user-attachments/assets/111c3f91-f077-431f-bcd9-f60fa7a1ba26) ![image](https://github.com/user-attachments/assets/80f939d3-b615-4235-a511-82238758788e) ![image](https://github.com/user-attachments/assets/dce99b55-c8b1-4cbe-8769-b82151b3d404) ![image](https://github.com/user-attachments/assets/6b9b962d-c73c-42b9-b240-aa07601de879) </p> </details> # Changelog :cl: - tweak: Added languages to certain entities that lacked them, including MMIs and positronic brains. - add: Polymorphing into another entity now preserves your languages and grammar.
This reverts commit 3209838.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description.
TODO
Media
Changelog
🆑