Fix suggestion: remove faulty symlink that causes installation fail #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible-core 2.15.9 introduces tarfilepath normalization and current symlink is inconsistent to that. See more details https://github.com/ansible/ansible/blob/080b5103bef75c4a1d19d576ea8ebf49e149b48b/changelogs/CHANGELOG-v2.15.rst#L34C195-L34C242
|
Thanks for the PR @d4gg4d I’ve merged this to master and re-published to Ansible Galaxy so let me know how you get on. The tests were previously using the symlink so no longer work right now, but this was a critical fix given the role couldn’t even be installed, I’ll revisit the tests problem as soon as I’m able. Thanks once again, much appreciated. |
|
newer 1.3.1 taken into use and works as expected 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansible-core 2.15.9 introduces tar filepath normalization and current symlink is inconsistent to that.
See more details https://github.com/ansible/ansible/blob/080b5103bef75c4a1d19d576ea8ebf49e149b48b/changelogs/CHANGELOG-v2.15.rst#L34C195-L34C242
I'm not sure if this symlink is still relevant and if so, what should be the replacement for it. Please advice or merge and release fixed version.