Dockerize scalpel #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed `run.sh` script * fixed docker volumes
ajmeese7
suggested changes
Jan 6, 2023
| docker run --rm -it \ | ||
| -v ${PWD}/device.img:/scalpel/device.img \ | ||
| -v ${PWD}/recovery:/scalpel/recovery \ | ||
| s4ros/scalpel $@ |
| ERRORS+=("No ${PWD}/device.img file available!") | ||
| fi | ||
|
|
||
| # if [[ ! -d ${PWD}/recovery ]]; then |
There was a problem hiding this comment.
Commented out code should be removed before pushing to production
| @@ -1,3 +1,26 @@ | |||
| # s4ros/scalpel | |||
| docker run --rm -it \ | ||
| -v $(pwd)/device.img:/scalpel/device.img \ | ||
| -v $(pwd)/recovery:/scalpel/recovery \ | ||
| s4ros/scalpel |
| @@ -1,3 +1,26 @@ | |||
| # s4ros/scalpel | |||
|
|
|||
| In courtesy of https://github.com/sleuthkit/scalpel | |||
There was a problem hiding this comment.
This segment should be removed, since this will actually be in the official sleuthkit repository
igorvoltaic
reviewed
Jan 6, 2023
Comment on lines
+5
to
+6
| RUN apt-get update && \ | ||
| apt-get install -y -qq --no-install-recommends \ |
There was a problem hiding this comment.
Suggested change
| RUN apt-get update && \ | |
| apt-get install -y -qq --no-install-recommends \ | |
| RUN apt update && \ | |
| apt install -y -qq --no-install-recommends \ |
it's time to let go of apt-get
There was a problem hiding this comment.
apt-get should still be used in scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.