Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Display rendered System and User prompts #12

Merged
merged 1 commit into from
Aug 27, 2024
Merged

add: Display rendered System and User prompts #12

merged 1 commit into from
Aug 27, 2024

Conversation

mrshu
Copy link
Collaborator

@mrshu mrshu commented Feb 27, 2024

  • Ensure that when jinja2 is used, the rendered versions of the System and User prompts are also shown in the UI.

mrshu
mrshu commented Feb 27, 2024
View reviewed changes
prompterator/main.py Outdated Show resolved Hide resolved
@mrshu mrshu force-pushed the mrshu/display-rendered-system-user-prompt branch from 8d4771e to 6291f6a Compare February 27, 2024 06:39
mrshu
mrshu commented Feb 27, 2024
View reviewed changes
prompterator/main.py Outdated Show resolved Hide resolved
sweco
sweco reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@sweco sweco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely helps, but there was some bug - if was not displaying unless your prompt looked somehow. But I remember having jinja there but it was still not showing. We need to test this a bit more.

@samsucik
Copy link
Collaborator

@sweco @vikion I made quite some changes to Marek's first version and I'm curious what you think of it -- not necessarily of the code but more of the actual user experience 🙂 Could you give it a try, ideally with a CSV file that has more than just the text column and also with prompts that use columns beyond text?

@samsucik samsucik requested a review from sweco April 11, 2024 14:29
@samsucik samsucik force-pushed the mrshu/display-rendered-system-user-prompt branch 2 times, most recently from 607ba92 to 4a3e52b Compare August 27, 2024 15:24
@mrshu @samsucik
add: Display rendered System and User prompts
9727b1e 
* Ensure that when jinja2 is used, the rendered versions of the System
  and User prompts are also shown in the UI.

Signed-off-by: mrshu <[email protected]>
@samsucik samsucik force-pushed the mrshu/display-rendered-system-user-prompt branch from 4a3e52b to 9727b1e Compare August 27, 2024 15:27
@samsucik samsucik merged commit 000a824 into main Aug 27, 2024
1 check passed
@samsucik samsucik deleted the mrshu/display-rendered-system-user-prompt branch August 27, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsucik samsucik Awaiting requested review from samsucik

@danielajass danielajass Awaiting requested review from danielajass

@sweco sweco Awaiting requested review from sweco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrshu @samsucik @sweco