Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use azure-identity to log into Azure. #13

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Use azure-identity to log into Azure. #13

merged 6 commits into from
Mar 12, 2024

Conversation

dastrupl
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mrshu mrshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the PR @dastrupl! There is only one small thing that I think would make sense to update. Would you mind taking a look at it?

Thanks!

prompterator/models/openai_models.py Outdated Show resolved Hide resolved
… model types to keep the original functionality."

This reverts commit 5577231.
…to control the type of identity used in Azure OpenAI.
Copy link
Collaborator

@mrshu mrshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @dastrupl -- it looks good!

README.md Outdated Show resolved Hide resolved
@mrshu mrshu merged commit a0ad185 into slidoapp:main Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants