Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reusing past labels DATANG-3799 #16

Merged
merged 4 commits into from
May 22, 2024

Conversation

samsucik
Copy link
Collaborator

@samsucik samsucik commented Apr 19, 2024

Jira task

How I designed this:

  • one can add past labels (where available) by switching a toggle
  • the labels are searched for across all the files in the sidebar, based on matching both the generated text column as well as all of the columns available to be used as inputs
  • these past labels are stored in a separate column but otherwise get treated like human labels in computing the overall score
  • when a fresh human label is available as well, it takes precedence over the past label
  • where multiple (contradicting) labels are available for a row, the most recent one is used (relying on the time-based ordering of datafiles in the sidebar)
  • in addition, one can choose to ignore (skip) rows with past labels to speed up the manual labelling process

All of these design decisions can be challenged but the current design at least supports @vikion in her efforts 🙂

@samsucik samsucik requested a review from sweco April 19, 2024 15:32
@samsucik samsucik self-assigned this Apr 22, 2024
Copy link
Collaborator

@sweco sweco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsucik, finally got to this 😊 Looks good, I only marked a few places that I found a bit harder to understand.

prompterator/main.py Outdated Show resolved Hide resolved
prompterator/main.py Outdated Show resolved Hide resolved
prompterator/main.py Outdated Show resolved Hide resolved
prompterator/main.py Outdated Show resolved Hide resolved
prompterator/utils.py Outdated Show resolved Hide resolved
@samsucik samsucik requested a review from sweco May 21, 2024 12:42
@samsucik samsucik merged commit 7fb0269 into main May 22, 2024
1 check passed
@samsucik samsucik deleted the samko/enable-reusing-past-labels branch May 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants