Support Azure OpenAI models DATANG-3500 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSkala
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Looks good to me @samsucik - also works nicely!
I only had one question about the poetry lock but if you ran also --no-update I think we can merge it :)
Co-authored-by: Daniel Skala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: DATANG-3500
As part of this change, I decided to also update the version of
openaiwe use. It was much simpler than dealing with the old version where one had to directly set attributes of the importedopenaimodule in order to use the Azure OpenAI models.