Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove image uploading to 3rd party service #9

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Remove image uploading to 3rd party service #9

merged 5 commits into from
Oct 25, 2024

Conversation

jozefizso
Copy link
Member

The xcresulttool will no longer process attached images and upload the to a 3rd party service.

Fixes #4

Fixes SECINC-79

@jozefizso jozefizso added the bug Something isn't working label Oct 25, 2024
@jozefizso jozefizso added this to the v3.0.0 milestone Oct 25, 2024
@jozefizso jozefizso self-assigned this Oct 25, 2024
DominikPalo
DominikPalo requested changes Oct 25, 2024
View reviewed changes
src/attachment.ts Show resolved Hide resolved
@DominikPalo DominikPalo added the security Security. label Oct 25, 2024
@jozefizso jozefizso merged commit 4cb8d03 into main Oct 25, 2024
8 of 17 checks passed
@jozefizso jozefizso deleted the fix/4_remove_image_uploads branch October 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikPalo DominikPalo DominikPalo approved these changes

@filipbodor filipbodor Awaiting requested review from filipbodor

@m-kovac m-kovac Awaiting requested review from m-kovac

Assignees

@jozefizso jozefizso

Labels
bug Something isn't working security Security.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Remove image uploading to 3rd party service
2 participants
@jozefizso @DominikPalo