Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add button 'type' attribute #43

Merged
merged 3 commits into from
Sep 23, 2024
Merged

feat: add button 'type' attribute #43

merged 3 commits into from
Sep 23, 2024

Conversation

alephao
Copy link
Contributor

@alephao alephao commented Sep 22, 2024

No description provided.

Copy link
Owner

@sliemeobn sliemeobn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

Sources/Elementary/HtmlAttributes.swift Outdated Show resolved Hide resolved
@alephao alephao requested a review from sliemeobn September 23, 2024 12:43
Copy link
Owner

@sliemeobn sliemeobn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sliemeobn sliemeobn merged commit bec31e2 into sliemeobn:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants