Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion of multi-line method arguments #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathanhefner
Copy link

The regexps responsible for converting method calls with blocks did not account for arguments split across multiple lines. This patch enables multi-line method arguments, as long as every line except the last ends with a comma (and zero or more spaces).

Fixes #40

This patch is intentionally limited in scope. It does not handle lines which end with, e.g. &&. If someone wants to compile a set of use cases, I can make a follow-up PR which tries to accommodate them.

The regexps responsible for converting method calls with blocks did not
account for arguments split across multiple lines.  This patch enables
multi-line method arguments, as long as every line except the last ends
with a comma (and zero or more spaces).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant