refactor: minor xpd_tools_constr changes, may fix #5

CMakeLists.txt

@@ -5,8 +5,8 @@ set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_C_STANDARD 17)
 
 # CMake Settings
-set(CMAKE_CXX_FLAGS "-O3 -fPIC -pedantic")
-set(CMAKE_C_FLAGS "-O3 -fPIC -pedantic")
+set(CMAKE_CXX_FLAGS "-O3 -fPIC -pedantic -Wall")
+set(CMAKE_C_FLAGS "-O3 -fPIC -pedantic -Wall")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 set(CMAKE_OSX_ARCHITECTURES "x86_64;arm64")
 

src/tools.cpp

@@ -1,12 +1,20 @@
 #include "xpdraw/tools.h"
 
+#include <string.h>
 #include <string>
 #include <XPLMPlugin.h>
 #include <XPLMUtilities.h>
 
 int xpVersion = -1;
 char xpPath[512];
 char pluginPath[512];
+char str3[512];
+
+char *xpd_tools_constr(const char *str1, const char *str2) {
+	strcpy(str3, str1);
+	strncat(str3, str2, sizeof(str3) - strlen(str3) - 1);
+	return str3;
+}
 
 char *xpd_tools_plugin_fp() {
 	XPLMEnableFeature("XPLM_USE_NATIVE_PATHS", 1);

src/xpdraw/tools.h

@@ -21,20 +21,14 @@
 extern "C" {
 #endif
 
-#include <string.h>
-
 /**
  * @brief Concentrate two C strings into one
  *
  * @param str1
  * @param str2
  * @return char*
  */
-inline char *xpd_tools_constr(const char *str1, const char *str2) {
-	char str3[256];
-	strcpy(str3, str1);
-	return strncat(str3, str2, sizeof(str3) - strlen(str3) - 1);
-}
+char *xpd_tools_constr(const char *str1, const char *str2);
 
 /**
  * @brief Returns the plugin's current path. Forces XPLM_USE_NATIVE_PATHS to true!