Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fortify small typos #239

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Fix Fortify small typos #239

merged 3 commits into from
Apr 29, 2024

Conversation

teoberi
Copy link
Contributor

@teoberi teoberi commented Apr 27, 2024

Cosmetic changes for Fortify

@@ -117,7 +117,7 @@ proccheck() {
fi
fi

#check for forifty source support
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make build needs run before checking in.

the hack/enable-git-hooks.sh script will enable the pre-commit hooks which will prevent committing without the render and do it for you so then its just adding it.

@teoberi teoberi requested a review from slimm609 April 28, 2024 11:25
@slimm609
Copy link
Owner

@slimm609
Copy link
Owner

tests are failing because you need to run make build and check in the results

@teoberi
Copy link
Contributor Author

teoberi commented Apr 28, 2024

tests are failing because you need to run make build and check in the results

I don't use git locally.

@slimm609
Copy link
Owner

tests are failing because you need to run make build and check in the results

I don't use git locally.

I will approve this one and generate it but for future MRs, I will not accept them without following the process so that the tests can properly run.

@slimm609 slimm609 merged commit a9bb52b into slimm609:main Apr 29, 2024
1 check failed
@teoberi
Copy link
Contributor Author

teoberi commented Apr 29, 2024

OK. I understood, I will take the necessary steps. Thank you.

@teoberi teoberi deleted the teoberi-Fortify-fix-typos branch April 29, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants